Skip to content

🎨 Hide entities when trash is emptied #7387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

🎨 Hide entities when trash is emptied #7387

wants to merge 2 commits into from

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Mar 18, 2025 •
edited
Loading

What do these changes do?

Whenever the trash is emptied (POST /v0/trash:empty), the entities are immediately hidden to improve responsiveness and feedback from the user perspective. The cleaning operations continue in background.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo added the bug buggy, it does not work as expected label Mar 18, 2025
@giancarloromeo giancarloromeo added this to the The Awakening milestone Mar 18, 2025
@giancarloromeo giancarloromeo self-assigned this Mar 18, 2025
@giancarloromeo giancarloromeo changed the title Hide entitities when trash is emptied 🎨 Hide entitities when trash is emptied Mar 18, 2025
@codecov
Copy link

codecov bot commented Mar 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.11%. Comparing base (728db70) to head (3e6da7d).
Report is 15 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7387      +/-   ##
==========================================
- Coverage   87.34%   84.11%   -3.23%     
==========================================
  Files        1712      661    -1051     
  Lines       66428    31656   -34772     
  Branches     1125      168     -957     
==========================================
- Hits        58020    26627   -31393     
+ Misses       8088     4971    -3117     
+ Partials      320       58     -262
Flag Coverage Δ
integrationtests 65.29% <25.00%> (-0.02%) ⬇️
unittests 87.30% <87.50%> (+0.79%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.55% <ø> (-12.72%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.08% <ø> (-1.04%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 85.84% <87.50%> (-0.06%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 728db70...3e6da7d. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giancarloromeo giancarloromeo changed the title 🎨 Hide entitities when trash is emptied 🎨 Hide entities when trash is emptied Mar 18, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 21, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@giancarloromeo giancarloromeo removed this from the The Awakening milestone Mar 25, 2025
@giancarloromeo giancarloromeo deleted the is7379/hide-entities-on-trash-empty branch March 25, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov will be requested when the pull request is marked ready for review pcrespov is a code owner

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg will be requested when the pull request is marked ready for review sanderegg is a code owner

@GitHK GitHK Awaiting requested review from GitHK GitHK will be requested when the pull request is marked ready for review GitHK is a code owner

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66 matusdrobuliak66 will be requested when the pull request is marked ready for review matusdrobuliak66 is a code owner

Assignees

@giancarloromeo giancarloromeo

Labels

bug buggy, it does not work as expected

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

when trash:empty called, hide all entities and then respond

1 participant

@giancarloromeo